fix(nx-python): resolve poetry export local path for windows #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [19.0.2](nx-python-v19.0.1...nx-python-v19.0.2) (2024-08-12) ### Bug Fixes * **nx-python:** resolve poetry export local path for windows ([#244](#244)) ([6b65b68](6b65b68))
|
🎉 This PR is included in version 19.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, when the projects has a local dependency and the build executor is called in a Windows machine the following error happen:
That happens because the
@nxlv/pythonplugin uses the output of thepoetry exportcommand, and the pattern for Mac/Linux is:-e file:///Users/...and for Windows is-e file:///C:/Users/.The resolved location for Mac/Linux is
/Users/...and/C:/Users/for Windows.Expected Behavior
The resolved location should stay as-is for Mac/Linux and change from
/C:/Users/toC:/Users/for Windows.